lkml.org 
[lkml]   [2008]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] mm: sparsemem memory_present() memory corruption fix

* Yinghai Lu <yhlu.kernel@gmail.com> wrote:

> > + unsigned long max_arch_pfn = 1ULL << (MAX_PHYSMEM_BITS-PAGE_SHIFT);
> >
> > and also check my analysis whether it is correct and whether it
> > matches the reported bug patterns. But otherwise the fix looks like
> > a safe fix for v2.6.25-final to me - it only filters out values
> > from sparsemem input that are nonsensical in the sparsemem
> > framework anyway.
>
> can you check why find_max_pfn() e820_32.c need to call
> memory_present? wonder if it can be removed.

this is the only call to memory_present() we do in 32-bit arch setup, so
it's required.

(the function find_max_pfn() is woefully misnamed, but that's a cleanup
- i just fixed this in x86.git.)

Ingo


\
 
 \ /
  Last update: 2008-04-16 02:47    [W:0.115 / U:1.332 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site