lkml.org 
[lkml]   [2008]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] omfs: add inode routines
On Tue, Apr 15, 2008 at 08:30:59PM +0200, Marcin Slusarz wrote:
> > + if (be32_to_cpu(omfs_sb->s_magic) != OMFS_MAGIC) {
>
> can be omfs_sb->s_magic != cpu_to_be32(OMFS_MAGIC)
> (cpu_to_be32 can be optimized away even on LE)

Good point, I'll change that.

> > + if (bh)
> > + brelse(bh);
> brelse(NULL) is safe to call

Yup, I saw that too. I dropped these and added the labels per Miklos'
suggestion.

> > + return ret;
> > +}
>
> this code leaks omfs_sbi_info (sbi)

This one I'm not seeing. FS core calls put_super if ret is nonzero so
this should be ok?

Thanks!
--
Bob Copeland %% www.bobcopeland.com



\
 
 \ /
  Last update: 2008-04-16 01:59    [W:0.207 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site