lkml.org 
[lkml]   [2008]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] x86: Implement prctl PR_GET_TSC and PR_SET_TSC
Arjan van de Ven wrote:
>
> Hi,
>
> why did you make this a configuration option? In general it's not
> a good idea to make userspace visible ABI's (PR_* clearly is one of these)
> a CONFIG option unless there's some HUGE space saving going on.
> I don't see that here....
>
> So can you explain your rationale for making this a config option?
>

I also saw no mention about performance impact, which need to be
considered whenever *anything* is proposed to be inserted into a hot
path. It may be (heck, *should be*) that the performance impact isn't
measurable, but that needs to be positively established.

-hpa


\
 
 \ /
  Last update: 2008-04-12 22:55    [W:0.096 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site