lkml.org 
[lkml]   [2008]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4 v2] [RFC] UIO: generic platform driver
    On Fri, Apr 11, 2008 at 02:41:34PM -0700, Greg KH wrote:
    > On Fri, Apr 11, 2008 at 12:48:35PM +0200, Uwe Kleine-K?nig wrote:
    > > Hello,
    > >
    > > Uwe Kleine-K?nig wrote:
    > > > + dev_warn(&pdev->dev, "device has more than "
    > > > + stringify(MAX_UIO_MAPS)
    > > This must read __stringify(MAX_UIO_MAPS). Sorry, I didn't compile test
    > > that.
    >
    > Care to send the latest version of this, I'm a bit lost as to what
    > people want me to apply...

    Hi Greg,
    PATCH 4/4 still has a problem. It uses some clock framework functions
    not available on every architecture. E.g. on x86_64 you can select this
    driver in menuconfig, but it won't compile.

    The first three patches are OK in my opinion. Uwe provided a second
    version of PATCH 1/4, PATCH 2/4 and PATCH 3/4 were alright in their
    original version. I added my Signed-off-by to 1-3, but not to 4.

    Thanks,
    Hans


    \
     
     \ /
      Last update: 2008-04-12 00:57    [W:0.019 / U:29.392 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site