Messages in this thread | | | Date | Fri, 11 Apr 2008 21:59:20 +0200 | From | "Hans J. Koch" <> | Subject | Re: [PATCH 4/4] [RFC] UIO: generic platform driver |
| |
On Fri, Apr 11, 2008 at 12:41:54PM +0200, Uwe Kleine-König wrote: > > problem? Please move the declaration to the top of the function.
> I'm not conviced and still prefer it that way. I gave way for your > requests in uio.c because it's your code. I want to leave it as it is > and hope you will accept that (as this is my code).
I looked around a bit and talked to some people. It seems that a local variable declaration within a for{} block is OK. I still don't like it, but I won't object any longer.
So, AFAICT you've only got that arch dependency problem left to solve.
Thanks, Hans
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |