lkml.org 
[lkml]   [2008]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patches in this message
    /
    Date
    From
    Subject[PATCH] x86: setup_trampoline() - fix section mismatch warning
    Hi Ingo,

    this patch fixes section mismatch warnings (on x86_64 host) in setup_trampoline(),
    which was referencing __initdata variables trampoline_data and trampoline_end.

    Patch is against x86/latest.

    Warning messages:
    WARNING: arch/x86/kernel/built-in.o(.cpuinit.text+0x2b6a): Section mismatch in reference from the function setup_trampoline()
    to the variable .init.data:trampoline_data
    The function __cpuinit setup_trampoline() references
    a variable __initdata trampoline_data.
    If trampoline_data is only used by setup_trampoline then
    annotate trampoline_data with a matching annotation.

    WARNING: arch/x86/kernel/built-in.o(.cpuinit.text+0x2b71): Section mismatch in reference from the function setup_trampoline()
    to the variable .init.data:trampoline_end
    The function __cpuinit setup_trampoline() references
    a variable __initdata trampoline_end.
    If trampoline_end is only used by setup_trampoline then
    annotate trampoline_end with a matching annotation.

    -Jacek

    PS: Hope that my email client won't break patch this time. In case it does - patch attached.

    ---

    diff --git a/arch/x86/kernel/trampoline_64.S b/arch/x86/kernel/trampoline_64.S
    index 4aedd0b..2a07e67 100644
    --- a/arch/x86/kernel/trampoline_64.S
    +++ b/arch/x86/kernel/trampoline_64.S
    @@ -32,7 +32,7 @@

    /* We can free up trampoline after bootup if cpu hotplug is not supported. */
    #ifndef CONFIG_HOTPLUG_CPU
    -.section .init.data, "aw", @progbits
    +.section .cpuinit.data, "aw", @progbits
    #else
    .section .rodata, "a", @progbits
    #endif
    diff --git a/arch/x86/kernel/trampoline_64.S b/arch/x86/kernel/trampoline_64.S
    index 4aedd0b..2a07e67 100644
    --- a/arch/x86/kernel/trampoline_64.S
    +++ b/arch/x86/kernel/trampoline_64.S
    @@ -32,7 +32,7 @@

    /* We can free up trampoline after bootup if cpu hotplug is not supported. */
    #ifndef CONFIG_HOTPLUG_CPU
    -.section .init.data, "aw", @progbits
    +.section .cpuinit.data, "aw", @progbits
    #else
    .section .rodata, "a", @progbits
    #endif
    \
     
     \ /
      Last update: 2008-04-10 21:23    [W:0.024 / U:64.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site