lkml.org 
[lkml]   [2008]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pop previous section in alternative.c
On Thu, Apr 10, 2008 at 10:55:44AM -0400, Steven Rostedt wrote:
>
> On Thu, 10 Apr 2008, Linus Torvalds wrote:
> >
> > But maybe we can see it in the resulting object file somehow, and do the
> > check there (the same way we do the init-section analysis). I assume the
> > ..size directive writes some debug info or similar, and we can create a big
> > warning when a size is unexpectedly huge and crosses section size
> > boundaries?
>
> I'm not sure how much this would help, but where I saw my red flag was
> examining the objdump and seeing this:
>
> 89: bf 69 00 00 00 mov $0x69,%edi
> 8e: e8 00 00 00 00 callq 93 <alternatives_smp_module_add+0x30>
> 8f: R_X86_64_PC32 .rodata+0x8c
>
>
> A call to .rodata??
Did you have any relocation record reflecting this reference?
The init_section stuff today rely purely on relocation
records and is easy to extend.

Sam


\
 
 \ /
  Last update: 2008-04-10 20:43    [W:0.093 / U:0.488 seconds]
©2003-2014 Jasper Spaans. Advertise on this site