lkml.org 
[lkml]   [2008]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pop previous section in alternative.c


On Thu, 10 Apr 2008, H. Peter Anvin wrote:

> Steven Rostedt wrote:
> >
> > Looking at the output below, shows that testing .sections in between
> > #APP and #NO_APP would in fact catch this bug.
> >
>
> Of course, The Right Thing[TM] would be for gcc to emit .pushsection ...
> .popsection around #APP ... #NO_APP.

No, that would not help anything. It would still be open to bugs in the
asm, ie if there was a unpaired "pushsection" there, making gcc emit the
section directives around it would just cause a _different_ bug.

So I don't think gcc does the wrong thing per se. It was clearly a bug in
our inline asm, and the blame is solidly on us.

Obviously, it would have been really nice if something like the assembler
had caught it with some simple sanity-test (ie I think the .size thing
would be a good sanity check _regardless_), so in that sense it's our bug
that might have been avoided with soem sanity testing, but on the other
hand, I can well understand that gas didn't do it - since it would matter
only for totally buggy code that was never emitted by the compiler.

Gas historically used to not do any sanity-checking what-so-ever, and was
very much meant to be just for compiler output (which is why #APP exists
in the first place - to mark places that aren't pure compiler input). It's
actually improved immensely in that area and now is useful as a
traditional human-usable assembler with lots of support like macros etc.

Linus


\
 
 \ /
  Last update: 2008-04-10 19:41    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site