[lkml]   [2008]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] pop previous section in alternative.c

    On Thu, 10 Apr 2008, Andi Kleen wrote:

    > > I would say anytime there's a "^+.*\.section" there had better be a
    > > "^-.*\.section" or a "+.*.previous" matching it. Off hand I can't think o
    > > any exceptions to this rule although I may be wrong.
    > Second section is wrong because the compiler expects that the same
    > section is active afterwards and that can be different ones (like
    > init.text vs normal text)

    No the second section in my example is not wrong, because it starts with a
    "-", which in a patch would be a replacement of one .section with another,
    not an addition of two sections.

    > Also pushsection/popsection is also valid
    > So in summary valid section patterns are either
    > ..section / .previous or .pushsection .section .popsection

    But you are right with this part. Yeah, either a .section is replaced, or
    is added with a .previous, or is encapsulated with push and popsections.

    -- Steve

     \ /
      Last update: 2008-04-10 16:47    [W:0.018 / U:84.316 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site