Messages in this thread |  | | | Date | Thu, 10 Apr 2008 08:42:00 -0600 | | From | Jordan Crouse <> | | Subject | Re: x86: GEODE: add Virtual Systems Architecture detection |
| |
On 10/04/08 09:40 -0400, Andres Salomon wrote: > On Thu, 10 Apr 2008 09:10:57 +0100 > Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > > > On Wed, 9 Apr 2008 22:33:28 -0400 > > Andres Salomon <dilinger@queued.net> wrote: > > > > > > > > This is generic VSA detection. It's used by OLPC to determine whether or > > > not the BIOS contains VSA, but since other BIOSes are coming out that don't > > > use the VSA (ie, tinybios), it might end up being useful for others. > > > > NAK - but minor > > > > This is a check for *VSA2* which is not the same as VSA1 (Cyrix one) and > > for older systems that actually matters as you may have VSA1 or VSA2 and > > they are detected differently. > > > > Excellent point. Can we extend this to check for a VSA1-specific > string, or does VSA1 not have a similar signature?
I don't think we need to worry about it. 99.99% of Geode systems run with VSA happily transparent in the background, and thus would have no good reason to check for it. Certainly, there are no processors with VSA1 that would care to check.
But Alan does have a good point - we should name it vsa2 for strict correctness.
Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.
|  |