Messages in this thread | | | Date | Tue, 1 Apr 2008 10:43:03 +0300 | From | "Pekka Enberg" <> | Subject | Re: [RFC PATCH 25/26] UBIFS: add debugging stuff |
| |
Hi Artem,
On Tue, Apr 1, 2008 at 9:20 AM, Artem Bityutskiy <dedekind@yandex.ru> wrote: > Yeah, we will remove this later, keep it for now because it is very > convenient. I guess you refer the /proc/slab_allocations feature. > We found it less appropriate because it needs additional scripts to > be run to detect leaks, while this simple just hack makes UBIFS print > a message if there is a leak, which is just easier for us.
Why not fix it then to fit your needs? You do need leak detection after you're in the mainline too, don't you?
On Tue, Apr 1, 2008 at 9:20 AM, Artem Bityutskiy <dedekind@yandex.ru> wrote: > That was introduced to test the UBIFS shrinker, and to make sure > there are no races and everything works fine. Yes, will be removed > later.
It sounds useful and necessary for developing in the mainline as well so you might want to reconsider making it a standalone module in mm/.
Pekka
| |