lkml.org 
[lkml]   [2008]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] x86: Change x86 to use generic find_next_bit
    Date

    On Sun, 9 Mar 2008 21:11:52 +0100, "Ingo Molnar" <mingo@elte.hu> said:
    > * Alexander van Heukelum <heukelum@mailshack.com> wrote:
    > > --- a/lib/find_next_bit.c
    > > +++ b/lib/find_next_bit.c
    > > @@ -15,6 +15,8 @@
    > > #include <asm/byteorder.h>
    > >
    > > #define BITOP_WORD(nr) ((nr) / BITS_PER_LONG)
    > > +#undef find_next_bit
    > > +#undef find_next_zero_bit
    >
    > this bit looks weird - did you need it for testing?

    Worse, it's needed to get x86_64 to compile.

    They are defined in include/asm-x86/bitops_64.h (which gets
    included). They are used to optimize the case where the
    bitmap size is known at compile time and not larger than
    BITS_PER_LONG. Undeffing them here is the easiest way to get
    things to compile, here.

    Greetings,
    Alexander

    --
    http://www.fastmail.fm - The way an email service should be



    \
     
     \ /
      Last update: 2008-03-09 21:35    [W:3.116 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site