lkml.org 
[lkml]   [2008]   [Mar]   [9]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSun, 9 Mar 2008 11:12:03 -0700
FromRandy Dunlap <>
SubjectRe: [PATCH 1/4] gxfb: Replace FBSIZE config option with a kernel argument
On Sat, 8 Mar 2008 20:19:50 -0500 Andres Salomon wrote:

> On Wed, 27 Feb 2008 19:58:39 -0500
> Andres Salomon <dilinger@queued.net> wrote:
> 
> > On Wed, 27 Feb 2008 16:31:05 -0800
> > Andrew Morton <akpm@linux-foundation.org> wrote:
> > 
> > > On Sat, 23 Feb 2008 01:10:45 -0500
> > > Andres Salomon <dilinger@queued.net> wrote:
> > > 
> > > > @@ -425,7 +424,10 @@ static int __init gxfb_setup(char *options)
> > > >  		if (!*opt)
> > > >  			continue;
> > > > 
> > > > -		mode_option = opt;
> > > > +		if (!strncmp(opt, "fbsize:", 7))
> > > > +			fbsize = simple_strtoul(opt+7, NULL, 0);
> > > > +		else
> > > > +			mode_option = opt;
> > > >  	}
> > > 
> > > The above shouldn't be necessary.
> > 
> > It looks like that's done in other drivers in case MODULE isn't defined.  I'm
> > assuming this is historical at this point, and manual options parsing can
> > be removed from all fb drivers at this point, or is there another reason
> > why manual parsing would be necessary?
> > 
> 
> Could I get an answer from the fbdevel folks about this?  It looks like
> the fb_get_options stuff is there for backwards compatibility.
> gxfb.fbsize=16777216 (for example) works regardless of whether or not
> CONFIG_MODULES is set.  
> 

It would be very nice to get Mr. Daplas back.

> > 
> > > 
> > > And it should have been documented in Documentation/kernel-parameters.txt.
> > 
> > Yeah, I wasn't actually sure about that; I did check for other fb drivers
> > documenting stuff in kernel-parameters.txt, and didn't see it.  It looks
> > like they instead document stuff in Documentation/fb/.  Which is preferred?
> > 
> 
> I'd also like an opinion on this.

My opinion (only) is that any subsystem that has lots of doc and/or
kernel parameters should put that info into Documentation/<subdir>/,
so adding to Documentation/fb/ is good.  (sound is another big
candidate for this.  All of those "snd-xyz=" entries in
kernel-parameters.txt don't actually help other than to say that there
are some user-settable parameters that someone has to go search for.)
We should probably also extend this entry in kernel-parameters.txt:

 	video=		[FB] Frame buffer configuration
			See Documentation/fb/modedb.txt.

to point to Documentation/fb/ for all frame buffer docs.

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2008-03-09 19:15    [from the cache]
©2003-2008