Messages in this thread |  | | | Date | Sat, 8 Mar 2008 18:40:30 +0000 | | From | "Duane Griffin" <> | | Subject | Re: [RFC, PATCH 4/6] jbd: refactor nested journal log recovery loop into separate functions |
On 08/03/2008, Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Mar 06, 2008 at 01:59:12AM +0000, Duane Griffin wrote:
> > +static int replay_data_block(
> > + journal_t *journal, struct buffer_head *obh, char *data,
> > + int flags, unsigned long blocknr)
>
> quite odd formatting, this should be more like:
>
> static int replay_data_block(journal_t *journal, struct buffer_head *obh,
> char *data, int flags, unsigned long blocknr)
>
> (same for the other new helpers)
OK, will change.
Thanks,
Duane.
--
"I never could learn to drink that blood and call it wine" - Bob Dylan
|  |