Messages in this thread | | | Subject | Re: [UPDATED v3][PATCH 5/7] regulator: sysfs ABI | From | Liam Girdwood <> | Date | Sat, 08 Mar 2008 17:26:03 +0000 |
| |
On Fri, 2008-03-07 at 21:52 -0800, Greg KH wrote: > On Fri, Mar 07, 2008 at 05:17:43PM -0800, David Brownell wrote: > > On Friday 07 March 2008, Mark Brown wrote: > > > On Fri, Mar 07, 2008 at 08:12:12AM -0800, Greg KH wrote: > > > > On Thu, Mar 06, 2008 at 06:12:05PM +0000, Liam Girdwood wrote: > > > > > > > > + Some regulator directories will contain a link called parent. > > > > > + This points to the parent or supply regulator if one exists. > > > > > > > I don't think this is needed, why not just parent the device properly in > > > > the device tree itself? > > > > > > The device tree would tend to show parent for the the control interfaces > > > for the regulators (typically I2C or SPI) but there is likely to be > > > little or no relationship between that and the power distribution in the > > > system. > > > > I find "parent" a bit awkward, and Greg won't be the only one to > > be asking that question. Maybe it'd be better named "supply"? > > Yes, "parent" means something in the driver model (the parent of the > device in the tree). I agree with the different wording like "supply" > if that makes sense. Or something else other than "parent". >
"supply" sounds good to me.
Liam
| |