Messages in this thread | | | Date | Sat, 8 Mar 2008 11:42:58 -0500 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/3] jbd2: replace potentially false assertion with if block |
| |
On Sat, Mar 08, 2008 at 04:40:46PM +0000, Duane Griffin wrote: > > That doesn't make any sense. They're initialized in module_init and > > destoryed in module_exit. They can never be zero at journal_load time > > unless you get random memory corruption overwriting exactly that pointer > > with zero. > > If jbd is a module, sure, but not if it is statically linked in. I > have the stacktraces to prove it :)
That text above was in reply to Andreas comment about checking it in journal_load. Your fix obviously does make sense althrough doing it differently as in my reply to your first series would be even better.
| |