Messages in this thread | | | Date | Sat, 8 Mar 2008 16:40:46 +0000 | From | "Duane Griffin" <> | Subject | Re: [PATCH 2/3] jbd2: replace potentially false assertion with if block |
| |
On 08/03/2008, Christoph Hellwig <hch@infradead.org> wrote: > On Fri, Mar 07, 2008 at 02:23:36PM -0700, Andreas Dilger wrote: > > > It would probably be prudent to verify that these caches are initialized > > at journal_load() time and either re-try to create the cache, and/or report > > an error in that case and refuse to continue mounting. > > That doesn't make any sense. They're initialized in module_init and > destoryed in module_exit. They can never be zero at journal_load time > unless you get random memory corruption overwriting exactly that pointer > with zero.
If jbd is a module, sure, but not if it is statically linked in. I have the stacktraces to prove it :)
Cheers, Duane.
-- "I never could learn to drink that blood and call it wine" - Bob Dylan
| |