Messages in this thread |  | | | From | "Duane Griffin" <> | | Date | Sat, 8 Mar 2008 13:26:14 +0000 | | Subject | Re: [PATCH 1/3] jbd2: eliminate duplicated code in revocation table init/destroy functions | |
On Fri, Mar 07, 2008 at 04:05:26PM -0800, Mingming Cao wrote:
> > > + if (!journal->j_revoke_table[0])
> > > + goto failed_alloc1;
> > > + if (jbd2_journal_init_revoke_table(journal->j_revoke_table[0], hash_size))
> >
> > (style) wrap at 80 columns.
> >
>
> checkpatch.pl catched this...fyi.
It did :)
After following recent LKML threads on this I figured it would probably
be more readable to leave it than fix it. I should have mentioned that,
sorry. Anyway, it is no longer an issue after addressing Andreas'
comments.
> Thanks for reviewing this Andreas.
My thanks, too. I really appreciate the quick and thorough review.
> The patch is already in ext4 candidate patch queue. FYI.
If I can do anything to simplify updating it with revised versions then
let me know.
> Mingming
Cheers,
Duane.
--
"I never could learn to drink that blood and call it wine" - Bob Dylan
|  |