lkml.org 
[lkml]   [2008]   [Mar]   [7]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
FromNeilBrown <>
DateFri, 7 Mar 2008 16:00:47 +1100
Subject[PATCH 001 of 2] md: Fix formatting error in /proc/mdstat.
If an md array is "auto-read-only", then this appears in /proc/mdstat
as

   /dev/md0: active(auto-read-only)

whereas if it is truely readonly, it appears as

   /dev/md0: active (read-only)

The difference being a space. 

One program known to parse this file expects the space and gets badly
confused.  It will be fixed, but it would be best if what the kernel
generates is more consistent too.

Signed-off-by: Neil Brown <neilb@suse.de>

### Diffstat output
 ./drivers/md/md.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff .prev/drivers/md/md.c ./drivers/md/md.c
--- .prev/drivers/md/md.c	2008-03-07 15:51:24.000000000 +1100
+++ ./drivers/md/md.c	2008-03-07 15:52:21.000000000 +1100
@@ -5149,7 +5149,7 @@ static int md_seq_show(struct seq_file *
 			if (mddev->ro==1)
 				seq_printf(seq, " (read-only)");
 			if (mddev->ro==2)
-				seq_printf(seq, "(auto-read-only)");
+				seq_printf(seq, " (auto-read-only)");
 			seq_printf(seq, " %s", mddev->pers->name);
 		}
 

\
 
 \ /
  Last update: 2008-03-07 06:03    [from the cache]
©2003-2008