lkml.org 
[lkml]   [2008]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH][v2] Modify loop device to be able to manage partitions of the disk image
    From
    Date

    Le vendredi 07 mars 2008 à 13:33 +0100, Andreas Schwab a écrit :
    > Laurent Vivier <Laurent.Vivier@bull.net> writes:
    >
    > > +static int __init max_part_setup(char *str)
    > > +{
    > > + loop_max_part = simple_strtol(str, NULL, 0);
    > > + if (loop_max_part > (1UL << (MINORBITS - 1))) {
    > > + /* we must keep at least one bit for loop device number */
    > > + printk(KERN_ERR
    > > + "loop: loop_max_part cannot be greater than %d\n",
    > > + 1UL << (MINORBITS - 1));
    >
    > Since the argument is of type unsigned long you should use %ld or %lu.

    Yes, I wait for some more comments and I will re-send a [v3].

    Laurent
    --
    ----------------- Laurent.Vivier@bull.net ------------------
    "Programmers who subconsciously view themselves as artists
    will enjoy what they do and will do it better." D. Knuth

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-03-07 13:45    [W:0.021 / U:32.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site