lkml.org 
[lkml]   [2008]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Add cgroup support for enabling controllers at boot time
On Fri, 7 Mar 2008, Balbir Singh wrote:

> @@ -3010,3 +3020,16 @@ static void cgroup_release_agent(struct
> spin_unlock(&release_list_lock);
> mutex_unlock(&cgroup_mutex);
> }
> +
> +static int __init cgroup_disable(char *str)
> +{
> + int i;
> + for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
> + struct cgroup_subsys *ss = subsys[i];
> + if (!strcmp(str, ss->name)) {
> + ss->disabled = 1;
> + break;
> + }
> + }
> +}
> +__setup("cgroup_disable=", cgroup_disable);

This doesn't handle spaces very well, so isn't it possible for the name of
a current or future cgroup subsystem to be specified after cgroup_disable=
on the command line and have it disabled by accident?

> diff -puN Documentation/kernel-parameters.txt~cgroup_disable Documentation/kernel-parameters.txt
> --- linux-2.6.25-rc4/Documentation/kernel-parameters.txt~cgroup_disable 2008-03-06 17:57:32.000000000 +0530
> +++ linux-2.6.25-rc4-balbir/Documentation/kernel-parameters.txt 2008-03-06 18:00:32.000000000 +0530
> @@ -383,6 +383,10 @@ and is between 256 and 4096 characters.
> ccw_timeout_log [S390]
> See Documentation/s390/CommonIO for details.
>
> + cgroup_disable= [KNL] Enable disable a particular controller
> + Format: {name of the controller}
> + See /proc/cgroups for a list of compiled controllers
> +

This works on multiple controllers, though, if they follow
cgroup_disable=, so the documentation and format should reflect that.


\
 
 \ /
  Last update: 2008-03-06 20:19    [W:0.347 / U:0.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site