Messages in this thread | | | Date | Thu, 6 Mar 2008 10:05:59 -0800 | From | Greg KH <> | Subject | Re: [PATCH] Mark kobjects as unitialized |
| |
On Thu, Mar 06, 2008 at 11:20:50PM +0530, Balaji Rao wrote: > On Thursday 06 March 2008 10:35:14 pm Greg KH wrote: > <snip> > > Where exactly in the code does that happen? kobjects should not be > > "reused" as that implies that they are static, and not dynamically > > allocated, right? > > > > Which kobject is this? > Yes, its static. Here's the code from virt/kvm_main.c:1269 > > static struct sys_device kvm_sysdev = { > .id = 0, > .cls = &kvm_sysdev_class, > }; > > this sys_device is being registered/unregistered when kvm-intel is > loaded/unloaded.
Ah, ok. I'll add this patch then.
> > Ugh, is this the sys_device stuff? I hate that code... > > > Yes it is! But, why do you hate it ?
For reasons like this :)
kobjects should not be static. the sysdevice stuff was a hack when it was originally created and never touched since the mid 2.5 days. It needs to be fixed up a lot, and is on my TODO list, slowly getting closer to the top...
thanks,
greg k-h
| |