lkml.org 
[lkml]   [2008]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86_64: show apicid for cpu in proc
From
Date
"Yinghai Lu" <yhlu.kernel@gmail.com> writes:

> cpus_weight(per_cpu(cpu_core_map, cpu)));
> seq_printf(m, "core id\t\t: %d\n", c->cpu_core_id);
> seq_printf(m, "cpu cores\t: %d\n", c->booted_cores);
> + seq_printf(m, "apicid\t: %02x\n", c->apicid);

Seems a little redundant with the boot log, but ok.

But it's unclear to the user which apic ID is meant by that. There are
two different ones. The one in the LAPIC mapping and the one reported by
CPUID. They are not necessarily the same. I think you should clarify that
by renaming the field or perhaps report both.

-Andi


\
 
 \ /
  Last update: 2008-03-06 12:45    [W:0.282 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site