lkml.org 
[lkml]   [2008]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 5 Mar 2008 18:30:46 -0800 (PST)
FromAlex Dubov <>
SubjectRe: [PATCH 05/11] tifm: fix the MemoryStick host fifo handling code
--- Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 5 Mar 2008 03:02:22 +1100
> oakad@exemail.com.au wrote:
>
> > + buf = kmap_atomic(pg, KM_BIO_SRC_IRQ) + p_off;
>
> I am unable to convince myself that this driver always has local IRQs
> disabled when altering the KM_BIO_SRC_IRQ slot. Does it?
>

diff did rather bad job with this patch. The place in question looks like:

211: local_irq_save(flags);
212: buf = kmap_atomic(pg, KM_BIO_SRC_IRQ) + p_off;
....
....
223: kunmap_atomic(buf - p_off, KM_BIO_SRC_IRQ);
224: local_irq_restore(flags);


____________________________________________________________________________________
Never miss a thing. Make Yahoo your home page.
http://www.yahoo.com/r/hs

\
 
 \ /
  Last update: 2008-03-06 03:39    [from the cache]
©2003-2010