lkml.org 
[lkml]   [2008]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC, PATCH 3/6] jbd: only create debugfs entries if cache initialisation is successful
    Date
    JBD debugfs entries should only be created if cache initialisation is
    successful. At the moment they are being created unconditionally which will
    leave them dangling if cache (and hence module) initialisation fails.

    Signed-off-by: Duane Griffin <duaneg@dghda.com>
    ---
    This patch is an independent bug fix and following patches in this series do
    not depend on it.

    fs/jbd/journal.c | 5 +++--
    1 files changed, 3 insertions(+), 2 deletions(-)
    diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
    index 3f334a3..a868277 100644
    --- a/fs/jbd/journal.c
    +++ b/fs/jbd/journal.c
    @@ -1942,9 +1942,10 @@ static int __init journal_init(void)
    BUILD_BUG_ON(sizeof(struct journal_superblock_s) != 1024);

    ret = journal_init_caches();
    - if (ret != 0)
    + if (ret == 0)
    + jbd_create_debugfs_entry();
    + else
    journal_destroy_caches();
    - jbd_create_debugfs_entry();
    return ret;
    }

    --
    1.5.3.7


    \
     
     \ /
      Last update: 2008-03-06 03:11    [from the cache]
    ©2003-2011 Jasper Spaans. Advertise on this site