lkml.org 
[lkml]   [2008]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] Speedfreq-SMI call clobbers ECX

* Stephan Diestelhorst <langer_mann@web.de> wrote:

> @@ -184,7 +184,7 @@ static void speedstep_set_state (unsigne
> __asm__ __volatile__(
> "movl $0, %%edi\n"
> "out %%al, (%%dx)\n"
> - : "=b" (new_state), "=D" (result)
> + : "=b" (new_state), "=D" (result), "=c" (ecx_clobber)
> : "a" (command), "b" (function), "c" (state), "d" (smi_port), "S" (0)
> );

stupid suggestion: why not do a pusha/popa around those instructions, to
make sure everything is restored? This isnt a fastpath and being
conservative about SMI side-effects cannot hurt ...

Ingo


\
 
 \ /
  Last update: 2008-03-05 16:39    [W:0.071 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site