lkml.org 
[lkml]   [2008]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 11/17] Add memory mapping driver to RapidIO.
Date
From
Hi, Stephen,

Thanks! I'm considering to commit a updated patch or new code cleaning
patch.
How about your idea?

Cheers!
Wei

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Tuesday, March 04, 2008 6:38 PM
> To: Zhang Wei
> Cc: mporter@kernel.crashing.org; galak@kernel.crashing.org;
> linuxppc-dev@ozlabs.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 11/17] Add memory mapping driver to RapidIO.
>
> On Wed, 5 Mar 2008 00:29:56 +0800 Zhang Wei
> <wei.zhang@freescale.com> wrote:
> >
> > + if (!(rmem->virt = dma_alloc_coherent(NULL, rmem->size,
> > + &rmem->iores.start, GFP_KERNEL))) {
>
> Please separate assignments from tests.
>
> > + if ((ret = rio_space_claim(rmem))) {
>
> Again.
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>


\
 
 \ /
  Last update: 2008-03-05 03:03    [W:0.102 / U:1.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site