Messages in this thread | | | Subject | RE: [PATCH 11/17] Add memory mapping driver to RapidIO. | Date | Wed, 5 Mar 2008 09:59:38 +0800 | From | "Zhang Wei" <> |
| |
Hi, Stephen,
Thanks! I'm considering to commit a updated patch or new code cleaning patch. How about your idea?
Cheers! Wei
> -----Original Message----- > From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] > Sent: Tuesday, March 04, 2008 6:38 PM > To: Zhang Wei > Cc: mporter@kernel.crashing.org; galak@kernel.crashing.org; > linuxppc-dev@ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 11/17] Add memory mapping driver to RapidIO. > > On Wed, 5 Mar 2008 00:29:56 +0800 Zhang Wei > <wei.zhang@freescale.com> wrote: > > > > + if (!(rmem->virt = dma_alloc_coherent(NULL, rmem->size, > > + &rmem->iores.start, GFP_KERNEL))) { > > Please separate assignments from tests. > > > + if ((ret = rio_space_claim(rmem))) { > > Again. > > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au > http://www.canb.auug.org.au/~sfr/ >
| |