Messages in this thread Patch in this message |  | | | Date | Wed, 5 Mar 2008 00:15:31 +0100 (CET) | | From | Christian Kujau <> | | Subject | Re: WARNING: at drivers/usb/host/ehci-hcd.c:287 |
| |
On Tue, 4 Mar 2008, David Brownell wrote: >>> Or bettter yet, just removing it entirely. ISTR doing that in some >>> patches I've not yet sent for merging, and expect that's what my >>> preferred fix will be ... >> >> But removing the WARN_ON won't fix the problem. > > It fully resolves the $SUBJECT problem. :)
...and if it's a safe thing to do, I'm happy with it. I really have no clue why shutting up a WARN_ON has no (future) implications but if you say so I trust you :)
So now we're down to just:
--- linux-2.6/drivers/usb/host/ehci-hcd.c 2008-03-05 00:08:33.000000000 +0100 +++ linux-2.6/drivers/usb/host/ehci-hcd.c.edited 2008-03-05 00:09:45.000000000 +0100 @@ -284,7 +284,6 @@ static void ehci_iaa_watchdog(unsigned l u32 status, cmd;
spin_lock_irqsave (&ehci->lock, flags); - WARN_ON(!ehci->reclaim);
status = ehci_readl(ehci, &ehci->regs->status); cmd = ehci_readl(ehci, &ehci->regs->command); Right?
Thank you both for looking into this issue, Christian. -- BOFH excuse #285:
Telecommunications is upgrading.
|  |