lkml.org 
[lkml]   [2008]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block: fix residual byte count handling
Boaz Harrosh wrote:
>> - good_bytes = scsi_bufflen(cmd);
>> + good_bytes = scsi_bufflen(cmd) + cmd->request->data_len;
>
> Are you sure? is it not:
> + good_bytes = scsi_bufflen(cmd) + cmd->request->extra_len

You're right. Sorry about the confusion.

>> if (cmd->request->cmd_type != REQ_TYPE_BLOCK_PC) {
>> drv = scsi_cmd_to_driver(cmd);
>> if (drv->done)
>>
>>
>
> I hate this patch. I wish you could maybe take the extra_len into
> account inside blk_end_request. The padding should be transparent
> to all concerned but the requesting LLD and the internals of the
> block layer. If block layer added padding it should take that into
> account on completion. My $0.2.

Yeah, I hate it too. As I've been saying all along, I think it just
should be rq->data_len.

--
tejun


\
 
 \ /
  Last update: 2008-03-04 19:39    [W:0.276 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site