Messages in this thread | | | Date | Tue, 04 Mar 2008 10:29:37 -0600 | From | Steve Wise <> | Subject | Re: [ofa-general] Re: [PATCH] iwch_create_cq off by one error |
| |
Hey Roland,
Are you going to pull this one in?
Thanks,
Steve.
Steve Wise wrote: > Acked-by: Steve Wise <swise@opengridcomputing.com> > > > Jon Mason wrote: >> The cxbg3 driver is unnecessarily decreasing the number of cq entries >> by one when creating a cq. This will cause an error of not having as >> many cqs as requested by the user, if the user requests a power of 2 >> cq length. >> >> Thanks, >> Jon >> >> Signed-off-by: Jon Mason <jon@opengridcomputing.com> >> --- >> drivers/infiniband/hw/cxgb3/iwch_provider.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c >> b/drivers/infiniband/hw/cxgb3/iwch_provider.c >> index f0c7775..800ef6d 100644 >> --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c >> +++ b/drivers/infiniband/hw/cxgb3/iwch_provider.c >> @@ -188,7 +188,7 @@ static struct ib_cq *iwch_create_cq(struct >> ib_device *ibdev, int entries, int ve >> return ERR_PTR(-ENOMEM); >> } >> chp->rhp = rhp; >> - chp->ibcq.cqe = (1 << chp->cq.size_log2) - 1; >> + chp->ibcq.cqe = 1 << chp->cq.size_log2; >> spin_lock_init(&chp->lock); >> atomic_set(&chp->refcnt, 1); >> init_waitqueue_head(&chp->wait); > > _______________________________________________ > general mailing list > general@lists.openfabrics.org > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general > > To unsubscribe, please visit > http://openib.org/mailman/listinfo/openib-general
| |