Messages in this thread |  | | | Date | Mon, 3 Mar 2008 22:23:21 -0800 | | From | Greg KH <> | | Subject | Re: [PATCH] x86 pci: remove checking type for mmconfig probe v2 | |
On Sat, Mar 01, 2008 at 12:36:50AM -0800, Yinghai Lu wrote:
> On Fri, Feb 29, 2008 at 10:02 PM, Greg KH <greg@kroah.com> wrote:
> > On Thu, Feb 28, 2008 at 11:56:50PM -0800, Yinghai Lu wrote:
> > >
> > > doesn't need to check if it is type1 or type2. we can use raw_pci_ops dirctly.
> >
> > Why? is this because the ops are already set up? It would be nice to
> > add the "why this change is necessary and/or possible now" for the
> > changelog.
> yes.
> raw_pci_ops got assigned when check direct_type1 and direct_type2.
> and could used in hostbridge check to get MMCONF base.
>
> make mmconfig probe clean
> with checking if raw_pci_ops is assigned instead of passing type or
> checking type.
Ah, ok, that makes sense, thanks.
greg k-h
|  |