lkml.org 
[lkml]   [2008]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/17] Add memory mapping driver to RapidIO.
On Wed,  5 Mar 2008 00:29:56 +0800 Zhang Wei <wei.zhang@freescale.com> wrote:
>
> + if (!(rmem->virt = dma_alloc_coherent(NULL, rmem->size,
> + &rmem->iores.start, GFP_KERNEL))) {

Please separate assignments from tests.

> + if ((ret = rio_space_claim(rmem))) {

Again.

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-03-04 11:41    [W:0.136 / U:0.248 seconds]
©2003-2014 Jasper Spaans. Advertise on this site