Messages in this thread | | | Date | Mon, 31 Mar 2008 23:27:19 +0200 | From | Jiri Slaby <> | Subject | Re: [PATCH 2/4] Char: ip2, macros cleanup |
| |
On 03/28/2008 10:18 PM, Jiri Slaby wrote: > - remove i2os.h -- there was only macro to macro renaming or useless > stuff > - remove another uselless stuf (NULLFUNC, NULLPTR, YES, NO) > - use outb/inb directly > - use locking functions directly > - don't define another ROUNDUP, use roundup(x, 2) instead > - some comments and whitespace cleanup > - remove some commented crap > - prepend the rest by I2 prefix to not collide with rest of the world > like in following output (pointed out by akpm) > > In file included from drivers/char/ip2/ip2main.c:128: > drivers/char/ip2/i2ellis.h:608:1: warning: "COMPLETE" redefined > In file included from include/net/netns/ipv4.h:8, > from include/net/net_namespace.h:13, > from include/linux/seq_file.h:7, > from include/asm/machdep.h:12, > from include/asm/pci.h:17, > from include/linux/pci.h:951, > from drivers/char/ip2/ip2main.c:95: > include/net/inet_frag.h:28:1: warning: this is the location of the previous definition > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
NACK, this one is crap, ignore it.
| |