[lkml]   [2008]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/3] do_wait reorganization
    > This looks wrong, we shouldn't clear *retval if the child is EXIT_DEAD.

    You're right. Thanks for catching that.
    I think it should look like this:

    int ret = eligible_child(type, pid, options, p);
    if (ret <= 0)
    return ret;

    if (p->exit_state == EXIT_DEAD)
    return 0;

    * We don't reap group leaders with subthreads.
    if (p->exit_state == EXIT_ZOMBIE && !delay_group_leader(p))
    return wait_task_zombie(p, options, infop, stat_addr, ru);

    * It's stopped or running now, so it might
    * later continue, exit, or stop again.
    *retval = 0;

    if (task_is_stopped_or_traced(p))
    return wait_task_stopped(p, options, infop, stat_addr, ru);

    return wait_task_continued(p, options, infop, stat_addr, ru);

    What do you think?


     \ /
      Last update: 2008-03-31 22:33    [W:0.020 / U:55.400 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site