lkml.org 
[lkml]   [2008]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/5] falconide/q40ide: add ->atapi_*put_bytes and ->ata_*put_data methods
    On Mon, 31 Mar 2008, Geert Uytterhoeven wrote:
    > On Sun, 30 Mar 2008, Bartlomiej Zolnierkiewicz wrote:
    > > On Sunday 30 March 2008, Geert Uytterhoeven wrote:
    > > > On Sun, 30 Mar 2008, Bartlomiej Zolnierkiewicz wrote:
    > > > > * Add ->atapi_{in,out}put_bytes and ->ata_{in,out}put_data methods to
    > > > > falconide and q40ide host drivers (->ata_* methods are implemented on
    > > > > top of ->atapi_* methods so they also do byte-swapping now).
    > > > >
    > > > > * Cleanup atapi_{in,out}put_bytes().
    > > >
    > > > Thanks!
    > > >
    > > > One remaining issue (for which the fix has never been submitted upstream so
    > > > far) with Atari and Q40 is that due to the byteswapped interface, the driveid
    > > > is also byteswapped, so it has to be unswapped again in ide_fix_driveid().
    > >
    > > My patch causes unswapping for _all_ data coming from the device so I wonder
    > > whether the ide_fix_driveid() fix is still needed?
    >
    > I'll give it a try on Aranym...

    Oops, just applying this series of 5 patches is not sufficient, I get
    lots of rejects...

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds


    \
     
     \ /
      Last update: 2008-03-31 08:07    [W:0.022 / U:7.736 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site