lkml.org 
[lkml]   [2008]   [Mar]   [30]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 29 Mar 2008 23:25:10 -0500
FromPaul Jackson <>
SubjectRe: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct setup_data
Huang wrote:
> +	__u32	payload_offset;
> +	__u32	payload_length;

This seems to be the descriptor for an incoming compressed
kernel image, right?  What is it doing in this patchset?

In your PATCH 4/4 to Documentation/i386/boot.txt, I can see
that there already existed documentation of these two payload
fields:

 0248/4	2.08+	payload_offset	Offset of kernel payload
 024C/4	2.08+	payload_length	Length of kernel payload

However, that documentation is just a useless rephrasing of the
variable names, with the added word "kernel".  Is this a compressed
kernel image?  If so, could that documentation be improved, perhaps as:

 0248/4	2.08+	payload_offset	Offset of compressed kernel payload
 024C/4	2.08+	payload_length	Length of compressed kernel payload

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.940.382.4214


\
 
 \ /
  Last update: 2008-03-30 06:27    [from the cache]
©2003-2008