lkml.org 
[lkml]   [2008]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 8/8] x86_64: Support for new UV apic
    On Sun, Mar 30, 2008 at 7:12 PM, Jack Steiner <steiner@sgi.com> wrote:
    > > > Did you test it on non UV_X2APIC box?
    > >
    > > anyway the read_apic_id is totally wrong, even for your UV_X2APIC box.
    > > because id=apic_read(APIC_ID) will have apic_id at bits [31,24], and
    > > id |= __get_cpu_var(x2apic_extra_bits) is assuming that is on bits [5,0]
    > >
    > > so you even didn't test in your UV_X2APIC box!
    > >
    >
    > It works fine on UV_X2APIX boxes because the double shift does
    > not occur. However, support for UV_X2APIC is dependent on
    > x2apic code that is not yet in the tree. Once the APIC
    > is switched into x2apic mode, the apicid is located in the LOW
    > bits of the apicid register, not the HIGH bits.

    oh, so that will need have new version GET_APIC_ID too.

    YH


    \
     
     \ /
      Last update: 2008-03-31 04:27    [W:4.745 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site