lkml.org 
[lkml]   [2008]   [Mar]   [3]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 3 Mar 2008 11:39:33 +0100
FromIngo Molnar <>
SubjectRe: [2.6 patch] acpi/battery.c: make 2 functions static
* Sam Ravnborg <sam@ravnborg.org> wrote:

> >From compiler-gcc.h:> >> > #define inline          inline          __attribute__((always_inline))> > So unless I am missing something obvious then each time we say inline 
> to a function we require gcc to inline the function.
> > It is my impression that today we only say inline if really needed and 
> otherwise let gcc decide. So in almost all cases inlise should just be 
> nuked?

no, what we should nuke is this always_inline definition. That was 
always the intention of FORCED_INLINE, and the removal of FORCED_INLINE 
was to _remove the forcing_, not to make it unconditional.

so Adrian, if you knew about this bug all along, you might as well have 
reported it :-/

	Ingo


\
 
 \ /
  Last update: 2008-03-03 11:43    [from the cache]
©2003-2008