lkml.org 
[lkml]   [2008]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 2/2] x86, fpu: lazy allocation of FPU area - v3
    On Mon, Mar 03, 2008 at 08:20:12PM -0500, Christoph Hellwig wrote:
    > On Mon, Mar 03, 2008 at 03:02:46PM -0800, Suresh Siddha wrote:
    > > + /*
    > > + * Memory allocation at the first usage of the FPU and other state.
    > > + */
    > > + if (!tsk->thread.xstate)
    > > + tsk->thread.xstate = kmem_cache_alloc(task_xstate_cachep, GFP_KERNEL);
    >
    > Please don't do over 80 char lines.

    Ok.

    > Also don't we need some kind of error handling here?

    Currently it uses SLAB_PANIC.

    thanks,
    suresh


    \
     
     \ /
      Last update: 2008-03-04 02:45    [W:0.023 / U:0.404 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site