lkml.org 
[lkml]   [2008]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v3 -mm] LSM: Add security= boot parameter
On Sun, 2 Mar 2008, Ahmed S. Darwish wrote:

> Add the security= boot parameter. This is done to avoid LSM
> registration clashes in case of more than one bult-in module.
>
> User can choose a security module to enable at boot. If no
> security= boot parameter is specified, only the first LSM
> asking for registration will be loaded. An invalid security
> module name will be treated as if no module has been chosen.
>
> LSM modules must check now if they are allowed to register
> by calling security_module_enable(ops) first. Modify SELinux
> and SMACK to do so.

I think this can be simplified by folding the logic into
register_security(), rather than having a two-stage LSM registration
process.

So, this function would now look like

int register_security(ops, *status);

and set *status to LSM_WAS_CHOSEN (or similar) if the module being
registered was also chosen via the security= parameter. If there is no
value for the parameter, the first module to register is automatically
chosen, to preserve existing behavior.

The calling code can then decide what to do, e.g. not panic if
registration failed and the LSM was not chosen; panic on failure when it
was chosen.

> +static atomic_t security_ops_enabled = ATOMIC_INIT(-1);

I'd suggest getting rid of this atomic and using a spinlock to protect the
global chosen_lsm string, which is always filled when an LSM registers.

>
> +/* Save user chosen LSM */
> +static int __init choose_lsm(char *str)
> +{
> + strncpy(chosen_lsm, str, SECURITY_NAME_MAX);
> + chosen_lsm[SECURITY_NAME_MAX] = NULL;

You should never need to set the last byte to NULL -- it's initialized to
that and by definition should never be overwritten.

> +int security_module_enable(struct security_operations *ops)
> +{
> + if (!ops || !ops->name)
> + return 0;

Lack of ops->name during registration needs to be a BUG_ON.


- James
--
James Morris
<jmorris@namei.org>


\
 
 \ /
  Last update: 2008-03-03 09:35    [W:0.067 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site