[lkml]   [2008]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC PATCH 1/3] block: add rq->complete_io hook for request stacking
    On Mon, Mar 3, 2008 at 8:24 AM, Hannes Reinecke <> wrote:

    > I would rather have rq->complete_io() to be pointing to blk_end_io in the
    > default case, this way rq->complete_io() would always be valid and we
    > would be saving us the if() clause.

    This is a good idea. But...

    > So when using my proposal this would just become:
    > {
    > BUG_ON(!rq->complete_io);
    > return rq->complete_io(rq, error, nr_bytes, 0, NULL);
    > }

    This "BUG_ON" is also an "if()" clause except
    it will panic. The box will panic if the function
    pointer is a null pointer and it won't be hard to
    sort out why. I suggest omitting the BUG_ON.


     \ /
      Last update: 2008-03-03 18:43    [W:0.022 / U:13.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site