lkml.org 
[lkml]   [2008]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/5] don't panic if /sbin/init exits or killed
    On 03/28, H. Peter Anvin wrote:
    >
    > Oleg Nesterov wrote:
    > >If the buggy init exits, the kernel panics. I see no point for this. It is
    > >very
    > >possible that the system is still usable enough, at least to read the logs
    > >and
    > >prepare the bug report.
    > >
    > >Change exit_child_reaper() to do BUG() instead of panic().
    > >
    > >Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
    >
    > This would be highly undesirable in a production system, since it would
    > leave the machine an unusable zombie. In a production system, the panic
    > can be made to reboot the system, bringing it back online.

    I can't agree. Following this logic, we should always use panic() instead
    of BUG().

    I think the system should try to use any chance to survive, and we have
    panic_on_oops.


    That said, Stephen has a good reason to nack this patch. But still I hope
    it is possible to find a simple solution. Not that I think this is really
    important, but this panic() is silly, imho.

    Oleg.



    \
     
     \ /
      Last update: 2008-03-29 11:55    [W:3.682 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site