lkml.org 
[lkml]   [2008]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] hotplug-memory: refactor online_pages to separate zone growth from page onlining
On Fri, 28 Mar 2008 22:48:21 -0700
Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> >> - if (onlined_pages)
> >> + if (onlined_pages) {
> >> + struct memory_notify arg;
> >> +
> >> + arg.start_pfn = pfn; /* ? */
> >> + arg.nr_pages = onlined_pages;
> >> + arg.status_change_nid = -1; /* ? */
> >> +
> >> memory_notify(MEM_ONLINE, &arg);
> >> + }
> >>
> > I think you should add "onlined" member instead of reusing nr_pages.
> >
>
> I suppose. What would I put into nr_pages? And anyway, there are no
> users for this notification...
>
My point is "Notifier" is expexted to work correctly and include precise
information regardless of users.

> > But, in general, I have no objection to this way.
> >
>
> The refactoring in general?
>

Separating online_pages() into some meaningful blocks. Then, you can
reuse some parts and avoid dupilication.

Thanks,
-Kame



\
 
 \ /
  Last update: 2008-03-29 07:25    [W:0.038 / U:1.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site