Messages in this thread | | | Date | Fri, 28 Mar 2008 09:52:25 -0700 | From | Badari Pulavarty <> | Subject | Re: [PATCH 4/5] [PPC] update lmb for hotplug memory add/remove |
| |
Kumar Gala wrote: > > On Mar 27, 2008, at 7:39 PM, Badari Pulavarty wrote: >> ppc kernel maintains information about logical memory blocks in >> lmb.memory structure at the boot time. Its not updated for >> hotplug memory add/remove. hotplug memory notifier for memory >> add/remove now updates lmb.memory. >> >> This information is useful for eHEA driver to find out the memory >> layout and holes. >> >> NOTE: No special locking is needed for lmb_add() and lmb_remove(). >> Calls to these are serialized by caller. (pSeries_reconfig_chain). >> >> Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com> >> --- >> arch/powerpc/platforms/pseries/hotplug-memory.c | 43 +++++++++++++++ >> include/linux/lmb.h | 3 - >> lib/lmb.c | 66 >> ++++++++++++++++++++---- >> 3 files changed, 102 insertions(+), 10 deletions(-) > > How is lmb_remove different than lmb_alloc? > > - k lmb_remove() can be used to punch a hole in to the existing memory block. lmb_alloc() tries to allocate for a given alignment, I don't think it can adjust the current entries. Isn't it ?
Thanks, Badari
| |