lkml.org 
[lkml]   [2008]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 09/10] Hugetlb common code update for System z.

* Gerald Schaefer <gerald.schaefer@de.ibm.com> wrote:

> include/asm-sh/hugetlb.h | 28 +++++++++++++++++++++++++
> include/asm-sparc64/hugetlb.h | 30 +++++++++++++++++++++++++++
> include/asm-x86/hugetlb.h | 28 +++++++++++++++++++++++++

these seem largely duplicated - shouldnt there be an
asm-generic/hugetlb.h instead, which asm/hugetlb.h could include to get
default behavior? It would probably reduce the linecount of your patch
as well.

Ingo


\
 
 \ /
  Last update: 2008-03-28 15:11    [W:0.378 / U:0.356 seconds]
©2003-2011 Jasper Spaans. Advertise on this site