lkml.org 
[lkml]   [2008]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] omfs: add bitmap routines
On Thu, Mar 27, 2008 at 11:51 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 27 March 2008, Bob Copeland wrote:
>
> > +static int nibblemap[] = {4, 3, 3, 2, 3, 2, 2, 1, 3, 2, 2, 1, 2, 1, 1, 0};
> > +
> > +unsigned long omfs_count_free(struct super_block *sb)
>
> I think it would be helpful to express this using hweight64.

Thanks for the review.

Yes, that would probably be cleaner. FWIW minix and affs both have
this sort of code too.

-Bob


\
 
 \ /
  Last update: 2008-03-28 14:29    [W:0.050 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site