Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 2/7] omfs: add inode routines | Date | Fri, 28 Mar 2008 04:42:45 +0100 |
| |
On Thursday 27 March 2008, Bob Copeland wrote: > +static struct inode *omfs_alloc_inode(struct super_block *sb) > +{ > + struct omfs_inode_info *oinf; > + oinf = (struct omfs_inode_info *) kmem_cache_alloc(omfs_inode_cachep, > + GFP_KERNEL); > + if (!oinf) > + return NULL; > + return &oinf->vfs_inode; > +}
If you could avoid the i_state member in omfs_inode_info, you could get rid of your own inode cache entirely. Your i_state seems to be mostly write-only, why is it needed in your file system?
Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |