lkml.org 
[lkml]   [2008]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/7] [NET]: uninline dev_alloc_skb, de-bloats a lot
Em Thu, Mar 27, 2008 at 05:52:12PM -0700, David Miller escreveu:
> From: Denys Vlasenko <vda.linux@googlemail.com>
> Date: Fri, 28 Mar 2008 00:36:59 +0100
>
> > Can you add a comment which explains the intent?
> >
> > +struct sk_buff *dev_alloc_skb(unsigned int length)
> > +{
> > + /* There is more code here than it seems:
> > + * __dev_alloc_skb is an inline */
> > + return __dev_alloc_skb(length, GFP_ATOMIC);
> > +}
> > +EXPORT_SYMBOL(dev_alloc_skb);
>
> I've applied his patch already, if you want this comment
> please submit the patch to add it and also please use
> the correct formatting of the comment.

Which is, of course:

/*
* There is more code here than it seems:
* __def_alloc_skb is an inline
*/

Ilpo: Keep up the debloating jihad/crusade/campaign/surge/kamppailla! 8-)

- arnaldo


\
 
 \ /
  Last update: 2008-03-28 02:45    [W:0.254 / U:1.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site