Messages in this thread | | | Date | Thu, 27 Mar 2008 12:55:42 -0700 | From | "H. Peter Anvin" <> | Subject | Re: processor flags |
| |
Cyrill Gorcunov wrote: > > And now I'm in confusion - the way of changing this code I see is the > following: > > - or use additional #ifdef CONFIG_VM86 in code where VM_MASK is used > (that would be ugly IMHO) > - rename VM_MASK to say X86_EFLAGS_VM86 with that #ifdef remained > - rest VM_MASK as it is > > How do you think? >
I think what we should do is:
- Rename VM_MASK to X86_VM_MASK (it's x86-specific after all) - Have:
#if CONFIG_VM86 # define X86_VM_MASK X86_EFLAGS_VM #else # define X86_VM_MASK 0 /* No V86 support */ #endif
-hpa
| |