lkml.org 
[lkml]   [2008]   [Mar]   [26]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 26 Mar 2008 08:09:47 +0100
FromStefan Richter <>
SubjectRe: [PATCH] firewire: fw-ohci: plug dma memory leak in AR handler
Jarod Wilson wrote:
> @@ -605,7 +606,7 @@ static void ar_context_tasklet(unsigned long data)
>  			buffer = handle_ar_packet(ctx, buffer);
> 
>  		dma_free_coherent(ohci->card.device, PAGE_SIZE,
> -				  buffer, buffer_bus);
> +				  start, start_bus);
>  		ar_context_add_page(ctx);

On the other hand, why do we free a page + allocate a page?
Why don't we re-initialize and re-add the old page?
-- 
Stefan Richter
-=====-==--- --== ==-=-
http://arcgraph.de/sr/

\
 
 \ /
  Last update: 2008-03-26 08:13    [from the cache]
©2003-2008